Support loading from NODE_PATH, fixes tkellen/node-liftoff#28 #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Fails on windows because of this: Example path: |
|
I'm conflicted about including this. It really belongs in Any thoughts @phated? |
Member
|
If we have to use substack modules, then we should handle the case in our lib. Just make sure it works cross platform |
Contributor
|
http://nodejs.org/api/modules.html#modules_loading_from_the_global_folders
|
|
Thanks @Meroje! |
tkellen
pushed a commit
that referenced
this pull request
Feb 24, 2015
Support loading from NODE_PATH, fixes #28
|
released as |
Contributor
Author
|
Thanks for your quick answers on this |
tkellen
pushed a commit
that referenced
this pull request
Jul 25, 2016
Support loading from NODE_PATH, fixes #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will pass NODE_PATH to resolve.sync when looking for the module to require, or empty array if undefined (default for most people) which behaves the same.